I18n sync #3523
Merged
I18n sync #3523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eys Across Locale Files processing#3510" This reverts commit fffa082.
… SubmitSaveAllSettings Keys Across Locale Files processing#3510
This was referenced Jun 12, 2025
Closed
raclim
approved these changes
Jun 24, 2025
There was a problem hiding this comment.
Thanks so much @ojuschugh1 for your work on this and @yugalkaushik for the review, this is great!
As a quick note, I updated the description as "Progress Towards" instead of "Fixes" so the issue doesn't close, since we have a few other translation files that still need to be addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress Towards #3510
Changes:
Here's a summary of the changes made:
Replaced "SubmitSaveAllSettings" with "SaveAccountDetails" in Hindi locale file.
Updated "Settings" to "My Account" (or its translation) in the AccountView section of the Hindi locale file.
The translations are now consistent across the Hindi language and match the English version. The UI should now display the correct text in Hindi.
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #3510