-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version switcher #3334
Open
davepagurek
wants to merge
37
commits into
processing:develop
Choose a base branch
from
davepagurek:version-switcher
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Version switcher #3334
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
15e426c
Initial version detection
davepagurek 5acd3ea
Half working version switcher
davepagurek e0342fb
Show version in picker
davepagurek cf963b7
Switch to controlled preferences tabs; create version button
davepagurek 5042faa
Add info for custom versions
davepagurek 066bdf6
Add placeholders for other settings
davepagurek 89f0d5e
Start to add code to do addon toggles
davepagurek 6bd28e9
Fix return values
davepagurek 1eac470
Add doctype
davepagurek de95b13
Make toggles actually do something!
davepagurek 7b4ae4e
Add button to revert p5.sound version after a change
davepagurek b209f84
Move useP5Version into a provider to persist state
davepagurek 22dee37
Add starburst on change to 2.0
davepagurek d85b7d5
Make toggling on restore instead of a button
davepagurek d6ff5ac
Add max height to version picker menu
davepagurek aeb8782
Make p5.sound regex more permissive
davepagurek 2de2cae
Merge branch 'develop' into version-switcher
davepagurek c1f9dce
Add admonition and copy to clipboard button
davepagurek 2279d3a
Use latest p5/p5.sound in textarea
davepagurek cae11eb
Style dropdown button
davepagurek 38b340e
Merge branch 'develop' into version-switcher
davepagurek 70fde43
Update versioning note + admonition
davepagurek 53a517b
Merge branch 'develop' into version-switcher
davepagurek a3c2931
Merge branch 'develop' into version-switcher
davepagurek 261fd12
Update admonition colors for contrast
davepagurek cb255e2
Add better hover state for version picker
davepagurek 9139d02
Add pencil icon next to p5 version
davepagurek 22871b5
Use fieldset and legend tags
davepagurek 3f9c28b
Use fieldsets, fix aria labels
davepagurek 9d2444f
Use gear icon
davepagurek 3349904
Use new wording for addons
davepagurek 2b2fb95
Add notification dot with label
davepagurek 0d9430a
Update aria format
davepagurek d7088fb
Move version indicator to the toolbar
davepagurek 45af524
Merge branch 'develop' into version-switcher
davepagurek 3ac6c95
Use new compatibility addon URL, support new p5.sound for 2.0, preemp…
davepagurek 55ab78e
Move indicator to the left, switch back to gear icon
davepagurek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
import React from 'react'; | ||
import PropTypes from 'prop-types'; | ||
|
||
export default function Admonition({ children, title }) { | ||
return ( | ||
<div className="admonition"> | ||
<p className="admonition__title"> | ||
<strong>{title}</strong> | ||
</p> | ||
{children} | ||
</div> | ||
); | ||
} | ||
|
||
Admonition.propTypes = { | ||
title: PropTypes.string.isRequired, | ||
children: PropTypes.node | ||
}; | ||
|
||
Admonition.defaultProps = { | ||
children: undefined | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davepagurek This was pending the CM6 upgrade which will need ~2-3 weeks (after p5.js 2.0 release in any case). So we can move forward without waiting to resolve this TODO but need to keep it in mind when the upgrade is happening, @raclim will coordinate!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I made this not break on the current version of CM so I think this TODO comment may be good to remove. I'll double-check this week!