Skip to content

Fix edit rename using keyboard controls on SketchList && CollectionList #3150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2024
Merged

Fix edit rename using keyboard controls on SketchList && CollectionList #3150

merged 2 commits into from
Jun 13, 2024

Conversation

PiyushChandra17
Copy link
Contributor

Fixes #2383

Changes:

  • Replaced onKeyUp with onKeyDown
  • Added e.preventDefault()

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

raclim
raclim approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for your work on this!

@raclim raclim merged commit bd97f91 into processing:develop Jun 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raclim raclim raclim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot edit names on SketchList or CollectionList using keyboard controls
2 participants
@PiyushChandra17 @raclim