Fixes #400 #401
Merged
Fixes #400 #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hylkedonker
force-pushed
the
feature/lgcssm-batched-gibbs
branch
from
0a6c0fc to
afbac6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
LinearGaussianConjugateSSM.fit_blocked_gibbsmisses the part that takes care of the batching ofemissionsandinputsover the leading axis (issue #400 ). This pull request correctsfit_blocked_gibbsto support the "nbatch" dimension by:vmaping over the forward filtering backwards samplingThis pull request is accompanied by a minimal unit test that tests batching.