Repository navigation
Lead with npm package names in the README and guides, and drop the scope prefix - #32
Merged
Merged
Conversation
The packages install from npm as @probitas-test/*, but the README listed them under their JSR names with JSR badges only, and the contributor guides named packages and wrote import examples with the JSR names, which source files no longer use. The README lists the npm names with npm badges first (JSR badges stay next to them), and the guides use the npm names, keeping @probitas/* only where they describe the JSR mirror. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N3xvJ1TaozjYSE6eoyo9mq
Scopes carried the JSR package name (@probitas/runner) because the release tooling used before the Bun migration matched them that way. The release plan script ignores a registry prefix, so the prefix only adds noise, and it names the JSR mirror rather than the npm package. Scopes are now the package name alone (runner, client-http). The tests use that form and keep covering prefixed scopes, which remain in the history the release plan reads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N3xvJ1TaozjYSE6eoyo9mq
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@probitas-test/*) with npm badges, followed by the JSR badges; the highlights, quick start, architecture, and related repositories sections use the npm names too..claude/): package names and import examples use the npm names;@probitas/*remains only where the JSR mirror is described.feat(runner): ...).scripts/release_plan.tsalready ignored a registry prefix, so only its doc comment and tests change; the tests keep covering prefixed scopes, which remain in the history.Why
Probitas 2 installs from npm, but after #31 the README still listed the packages under their JSR names with JSR badges only, and the contributor guides kept naming packages and writing imports in the JSR form that source files no longer use. The
@probitas/scope prefix dated from the release tooling used before the Bun migration; the in-repo release plan does not need it.Test Plan
bun run verifybun test scripts/release_plan_test.ts(bare and prefixed scopes)🤖 Generated with Claude Code
https://claude.ai/code/session_01N3xvJ1TaozjYSE6eoyo9mq