feat(api): enrich badges endpoint - #630
Open
lukevio wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the richer
GET /badgesresponse requested by #466.Why
The badge UI needs a canonical public badge list with unlock metadata, plus optional per-user earned state when a valid token is supplied.
How
categoryandunlockCriteriato each badge.?category=filtering.earnedandearnedAtonly for authenticated callers.Cache-Control: public, max-age=300only for anonymous responses.200 { badges: [] }.Test plan
./node_modules/.bin/vitest run apps/api/src/routes/badges.cache.test.ts./node_modules/.bin/vitest run apps/api/src/routes/badges.cache.test.ts apps/api/src/services/badges.test.ts./node_modules/.bin/prettier --check apps/api/src/routes/badges.ts apps/api/src/routes/badges.cache.test.tsgit diff --cached --no-color | node scripts/gitleaks.mjs detect --pipe --redact --config .gitleaks.toml --verbose./node_modules/.bin/tsc -p apps/api/tsconfig.json --noEmitcurrently blocked by existing unrelatedapps/api/src/routes/leaderboard.ts(196,1): error TS1128Note: the local Husky pre-commit hook invokes
pnpm gitleaks:pre-commit, but pnpm currently exits before running the script due ignored build-script approvals for@fingerprintjs/fingerprintjs-pro-reactand@sentry/cli. I ran the underlying staged-diff gitleaks command directly and it passed.Closes #466