-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle relative tsconfig.json paths #80
Conversation
@privatenumber could you take a look at this please? thanks! |
Actually took a look at the time and I was going to add a test but I went down a rabbit hole. Basically this needs a test to land. I don't mind doing it but might take some time. |
tried adding a test - let me know what you think (it does fail on |
🎉 This issue has been resolved in version 4.7.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Appreciate the PR @stefanprobst Thanks for working on this 🙏 |
this fixes a regression introduced in 4.7.3:
previously, the implicit base url used an absolute path (see here), which was changed to just using
path.dirname()
(see here)this resulted in different paths being resolved for the base url here - in the example from #79 this would be:
closes #79