Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deploy maci command #2190

Merged
merged 1 commit into from
Mar 5, 2025
Merged

refactor: deploy maci command #2190

merged 1 commit into from
Mar 5, 2025

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Feb 26, 2025

Description

Refactor deployMaci command

Related issue(s)

fix #1981

Confirmation

Important

We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical error feel free to message the team.

Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Mar 5, 2025 10:10am

@ctrlc03 ctrlc03 self-assigned this Feb 26, 2025
@ctrlc03 ctrlc03 force-pushed the refactor/deploy-maci branch from 39dbae3 to 4082bb0 Compare February 26, 2025 15:53
@ctrlc03 ctrlc03 force-pushed the refactor/deploy-maci branch from 4082bb0 to 3255601 Compare February 26, 2025 16:58
@ctrlc03 ctrlc03 force-pushed the refactor/deploy-maci branch from 3255601 to 1e81104 Compare February 27, 2025 10:51
@ctrlc03 ctrlc03 force-pushed the refactor/deploy-maci branch from 1e81104 to 16a87f9 Compare February 27, 2025 11:07
@ctrlc03 ctrlc03 marked this pull request as ready for review February 27, 2025 11:08
@ctrlc03 ctrlc03 force-pushed the refactor/deploy-maci branch 2 times, most recently from 49b999f to b462db5 Compare February 28, 2025 10:26
@ctrlc03 ctrlc03 force-pushed the refactor/deploy-maci branch from b462db5 to 413b02a Compare February 28, 2025 14:46
@ctrlc03 ctrlc03 force-pushed the refactor/deploy-maci branch 5 times, most recently from f4d0a87 to 8b75341 Compare February 28, 2025 17:22
@ctrlc03 ctrlc03 force-pushed the refactor/deploy-maci branch 2 times, most recently from 455f5e1 to 5246feb Compare February 28, 2025 17:49
@ctrlc03 ctrlc03 force-pushed the refactor/deploy-maci branch from 5246feb to 241d78c Compare March 3, 2025 15:23
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks, just added some code style comments and one refactoring suggestion.

@ctrlc03 ctrlc03 force-pushed the refactor/deploy-maci branch 2 times, most recently from beb8051 to 5771b7b Compare March 5, 2025 09:32
@ctrlc03 ctrlc03 requested a review from 0xmad March 5, 2025 09:32
@ctrlc03 ctrlc03 force-pushed the refactor/deploy-maci branch from 5771b7b to e7dd95e Compare March 5, 2025 10:02
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks!

@0xmad 0xmad merged commit 98a6b11 into dev Mar 5, 2025
23 checks passed
@0xmad 0xmad deleted the refactor/deploy-maci branch March 5, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Refactor SDK
2 participants