Skip to content

Remove redundant [aria-disabled] selectors in ActionList.module.css #7407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattcosta7 merged 2 commits into from
Jan 2, 2026
Merged

Remove redundant [aria-disabled] selectors in ActionList.module.css #7407

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac10b51
Initial plan
Copilot Jan 2, 2026
86bfda5
Remove redundant [aria-disabled] selectors in ActionList.module.css
Copilot Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/react/src/ActionList/ActionList.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@
}

/* PERFORMANCE: Use data-disabled on <li> instead of :has([aria-disabled], [disabled]) which scans descendants */
&:not([aria-disabled], [data-disabled='true'], [data-has-subitem='true']) {
&:not([data-disabled='true'], [data-has-subitem='true']) {
@media (hover: hover) {
&:hover,
&:active {
Expand Down Expand Up @@ -331,7 +331,6 @@
}

/* PERFORMANCE: data-disabled is set on the <li> by JS, avoiding :has() descendant scan */
&[aria-disabled='true'],
&[data-disabled='true'] {
& .ActionListContent * {
color: var(--control-fgColor-disabled);
Expand Down Expand Up @@ -374,7 +373,7 @@

/* When TrailingAction is in loading state, keep labels and descriptions accessible */
/* PERFORMANCE: scoped to direct child TrailingAction */
&:has(> .TrailingAction[data-loading='true']):not([aria-disabled='true']) {
&:has(> .TrailingAction[data-loading='true']):not([data-disabled='true']) {
/* Ensure labels and descriptions maintain accessibility contrast */
& .ItemLabel {
color: var(--fgColor-default);
Expand Down
Loading