Skip to content

[WIP] Update drag/resize performance in PageLayout based on feedback #7390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattcosta7 merged 3 commits into from
Dec 29, 2025
Merged

[WIP] Update drag/resize performance in PageLayout based on feedback #7390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
145749e
Initial plan
Copilot Dec 29, 2025
4ce3401
Fix CSS cascade issue by using CSS variable for drag handle backgroun…
Copilot Dec 29, 2025
e1c7461
Improve comment clarity about CSS cascade conflict avoidance
Copilot Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/react/src/PageLayout/PageLayout.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,8 @@
content: '';
position: absolute;
inset: 0;
background-color: var(--bgColor-neutral-muted);
/* stylelint-disable-next-line primer/colors */
background-color: var(--draggable-handle--bg-color, var(--bgColor-neutral-muted));
opacity: var(--draggable-handle--drag-opacity, 0);
transition: var(--draggable-handle--transition, opacity 150ms ease); /* compositor-friendly, disabled during drag */
border-radius: inherit; /* optional if you need rounded corners */
Expand Down
6 changes: 4 additions & 2 deletions packages/react/src/PageLayout/paneUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ const DATA_DRAGGING_ATTR = 'data-dragging'
/** Apply visual feedback and performance optimizations during drag */
export function setDraggingStyles({handle, pane, content}: DraggingStylesParams) {
// Handle visual feedback (must be inline for instant response)
handle?.style.setProperty('background-color', 'var(--bgColor-accent-emphasis)')
// Use CSS variable to control ::before pseudo-element background color.
// This avoids cascade conflicts between inline styles and pseudo-element backgrounds.
handle?.style.setProperty('--draggable-handle--bg-color', 'var(--bgColor-accent-emphasis)')
handle?.style.setProperty('--draggable-handle--drag-opacity', '1')
handle?.style.setProperty('--draggable-handle--transition', 'none')

Expand All @@ -20,7 +22,7 @@ export function setDraggingStyles({handle, pane, content}: DraggingStylesParams)

/** Remove drag styles and restore normal state */
export function removeDraggingStyles({handle, pane, content}: DraggingStylesParams) {
handle?.style.removeProperty('background-color')
handle?.style.removeProperty('--draggable-handle--bg-color')
handle?.style.removeProperty('--draggable-handle--drag-opacity')
handle?.style.removeProperty('--draggable-handle--transition')

Expand Down