Skip to content

[WIP] WIP address feedback on drag/resize performance in PageLayout #7389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattcosta7 merged 2 commits into from
Dec 29, 2025
Merged

[WIP] WIP address feedback on drag/resize performance in PageLayout #7389

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2513687
Initial plan
Copilot Dec 29, 2025
9ac234f
Fix changeset description to accurately reflect implementation
Copilot Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .changeset/optimized-page-layout-resize.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,13 @@
PageLayout: Optimize drag/resize performance with inline styles and new optimizations

**Refactored:**
- Apply CSS containment via inline styles instead of `[data-dragging]` attribute selectors (O(1) vs O(n) selector matching)
- Use direct attribute selectors (`.Pane[data-dragging='true']`) instead of descendant selectors for CSS containment (O(1) vs O(n) selector matching)
- Extract optimization utilities to `paneUtils.ts`
- Use CSS variable for drag handle visual feedback
- Apply drag handle visual feedback via inline styles and CSS variables

**Added:**
- `content-visibility: auto` during drag/resize to skip off-screen content rendering

- rAF throttle for drag updates (one update per frame, latest position wins)
- Containment during window resize (parity with drag)

**Removed:**
- `[data-dragging]` attribute and associated CSS descendant selectors

These changes improve style recalculation performance on large DOMs (100k+ nodes) by eliminating descendant selector traversal.