update SelectPanel Multi Select Modal story #7354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e5f2b35 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
requested a deployment
to
storybook-preview-7354
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the MultiSelectModal story to implement deferred save behavior, where changes made within the modal are not reflected in the button label until the user explicitly clicks the Save button. Canceling or clicking outside the modal discards any unsaved changes.
Key Changes
- Added
savedSelectionstate to track the committed/saved selection separately from the workingselectedstate - Updated button text to display
savedSelectioninstead of the currentselecteditems, preventing real-time updates while the modal is open - Enhanced
onOpenChangehandler to only updatesavedSelectionwhen the modal closes with gesture type 'selection' (Save button clicked)
Co-authored-by: Copilot <[email protected]>
llastflowers
added
the
integration-tests: skipped manually
Contributor
Author
|
Integration tests skipped; Storybook-only changes in this PR |
jonrohan
approved these changes
Dec 19, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update SelectPanel Multi Select Modal story to not update labels unless user saves changes in modal
Closes https://github.com/github/primer/issues/6131
Changelog
Changed
Changes made in SelectPanel Multi Select Modal variant are now no longer reflected in the background via labels until user saves changes in the modal. Canceling or clicking outside the modal will also discard any unsaved changes.
Rollout strategy
Testing & Reviewing
Merge checklist