Skip to content

Conversation

@lesliecdubs
Copy link
Member

Is this CODEOWNERS specification still needed? If so, I've updated it to not point to @langermank who has moved on from GitHub.

Changelog

New

Changed

Changed CODEOWNER settings in the repo

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why - no consumer-facing change

Copilot AI review requested due to automatic review settings December 17, 2025 20:08
@lesliecdubs lesliecdubs requested a review from a team as a code owner December 17, 2025 20:08
@changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2025

⚠️ No Changeset found

Latest commit: 2ccabd2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lesliecdubs lesliecdubs requested a review from jonrohan December 17, 2025 20:09
@github-actions github-actions bot added the staff Author is a staff member label Dec 17, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CODEOWNERS specification for the legacy-theme directory, replacing a reference to an individual user (@langermank) who has left GitHub with the team @primer/design-reviewers. However, the path specified in the CODEOWNERS file does not match the actual repository structure.

Key Changes:

  • Changed ownership of ./src/legacy-theme/ from @langermank to @primer/design-reviewers

Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the file is still valid. However, this path doesn't exist like copilot pointed out. I think we can remove the entry or update the path, either works

Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@francinelucca francinelucca added skip changeset This change does not need a changelog integration-tests: skipped manually Changes in this PR do not require an integration test labels Dec 18, 2025
@lesliecdubs lesliecdubs added this pull request to the merge queue Dec 23, 2025
Merged via the queue into main with commit b33b93c Dec 23, 2025
52 checks passed
@lesliecdubs lesliecdubs deleted the lcw/updateCodeowners branch December 23, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants