-
Notifications
You must be signed in to change notification settings - Fork 647
Update CODEOWNERS for legacy-theme directory #7351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the CODEOWNERS specification for the legacy-theme directory, replacing a reference to an individual user (@langermank) who has left GitHub with the team @primer/design-reviewers. However, the path specified in the CODEOWNERS file does not match the actual repository structure.
Key Changes:
- Changed ownership of
./src/legacy-theme/from@langermankto@primer/design-reviewers
francinelucca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the file is still valid. However, this path doesn't exist like copilot pointed out. I think we can remove the entry or update the path, either works
Co-authored-by: Copilot <[email protected]>
francinelucca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
Is this CODEOWNERS specification still needed? If so, I've updated it to not point to
@langermankwho has moved on from GitHub.Changelog
New
Changed
Changed CODEOWNER settings in the repo
Removed
Rollout strategy