Skip to content

perf(SelectPanel): Document acceptable :has() selector usage #7332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattcosta7 wants to merge 1 commit into from
Closed

perf(SelectPanel): Document acceptable :has() selector usage #7332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/perf-selectpanel-has-selector.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@primer/react': patch
---

perf(SelectPanel): Document acceptable :has() selector usage

Added documentation explaining why the :has(input:placeholder-shown) selector is acceptable.
7 changes: 6 additions & 1 deletion packages/react/src/experimental/SelectPanel2/SelectPanel.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,12 @@
.TextInput {
padding-left: var(--base-size-8) !important;

/* stylelint-disable-next-line selector-class-pattern */
/*
* NOTE: Uses descendant :has() - input is not direct child of TextInputWrapper
* due to TextInputInnerVisualSlot wrappers. This is acceptable performance
* as the search is scoped to this single element's subtree.
*/
/* stylelint-disable-next-line selector-class-pattern -- global class from TextInput */
&:has(input:placeholder-shown) :global(.TextInput-action) {
display: none;
}
Expand Down
Loading