Skip to content

perf(ButtonGroup): Scope :has() selector to direct child for O(1) lookup #7328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mattcosta7 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

perf(ButtonGroup): Scope :has() selector to direct child for O(1) lookup #7328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ee35aa
perf(ButtonGroup): Scope :has() selector to direct child for O(1) lookup
mattcosta7 Dec 15, 2025
e497cb2
Merge branch 'main' into perf/buttongroup-has-selector
mattcosta7 Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/perf-buttongroup-has-selector.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

perf(ButtonGroup): Scope :has() selector to direct child for O(1) lookup
3 changes: 2 additions & 1 deletion packages/react/src/ButtonGroup/ButtonGroup.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@
}

/* this is a workaround until portal based tooltips are fully removed from dotcom */
&:has(div:last-child:empty) {
/* PERFORMANCE: Scope to direct child for O(1) lookup */
&:has(> div:last-child:empty) {
button,
a {
border-radius: var(--borderRadius-medium);
Expand Down
Loading