Skip to content

perf(Button): Replace :has(.Visual) with data-no-visuals attribute #7327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mattcosta7 wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

perf(Button): Replace :has(.Visual) with data-no-visuals attribute #7327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6617a3
perf(Button): Replace :has(.Visual) with data-no-visuals attribute
mattcosta7 Dec 15, 2025
6c9ba24
Merge branch 'main' into perf/button-has-selector
mattcosta7 Dec 16, 2025
1f099fc
Merge branch 'main' into perf/button-has-selector
mattcosta7 Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/perf-button-has-selector.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
'@primer/react': patch
---

perf(Button): Replace :has(.Visual) with data-no-visuals attribute

Replace `:has(.Visual)` selectors with `[data-no-visuals]` attribute checks to avoid descendant DOM scans.
Added documentation comments explaining acceptable :has() usage patterns.
19 changes: 13 additions & 6 deletions packages/react/src/Button/ButtonBase.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
justify-content: space-between;
gap: var(--base-size-8);

/* NOTE: Uses descendant :has() - button has very few children (icon, text, kbd). Acceptable. */
&:has([data-kbd-chord]) {
padding-inline-end: var(--base-size-6);
}
Expand Down Expand Up @@ -173,6 +174,7 @@
margin-right: var(--control-large-gap);
}

/* NOTE: Uses descendant :has() - button has very few children (icon, text, kbd). Acceptable. */
&:has([data-kbd-chord]) {
padding-inline-end: var(--base-size-8);
}
Expand Down Expand Up @@ -580,12 +582,13 @@
}
}

/* PERFORMANCE: Use data-no-visuals attribute instead of :has(.Visual) to avoid descendant scan */
[data-a11y-link-underlines='true'] &:where([data-variant='link']) {
&:not(:has(.Visual)) {
&:where([data-no-visuals='true']) {
text-decoration: underline;
}

&:has(.Visual) {
&:not([data-no-visuals='true']) {
background-image: linear-gradient(to right, currentColor, currentColor);
background-size: 100% 1.5px;
background-position: 0 calc(100% - 2px);
Expand All @@ -598,12 +601,12 @@
}

[data-a11y-link-underlines='false'] &:where([data-variant='link']) {
&:not(:has(.Visual)) {
&:where([data-no-visuals='true']) {
text-decoration: none;
background-image: none;
}

&:has(.Visual) {
&:not([data-no-visuals='true']) {
background-image: none;
}
}
Expand Down Expand Up @@ -632,8 +635,12 @@
}
}

/* Icon-only + Counter */

/*
* Icon-only + Counter
* NOTE: Uses descendant :has() - leadingVisual and text are nested inside
* buttonContent wrapper. This is acceptable as the search is scoped to
* this single button element's subtree (small DOM).
*/
&:where([data-has-count]):has([data-component='leadingVisual']):not(:has([data-component='text'])) {
/* stylelint-disable-next-line primer/spacing */
padding-inline: var(--control-medium-paddingInline-condensed);
Expand Down
Loading