Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 13, 2025

Two CSS selector changes in ActionList broke VRT tests by not matching the actual DOM structure.

Changes

Restored aria-disabled check in hover state selector (line 129)

  • Changed from &:not([data-disabled='true'], ...) back to &:not([aria-disabled], [data-disabled='true'], ...)
  • When listSemantics is true, aria-disabled is set on the <li> element itself, not just data-disabled
  • Without this check, disabled items incorrectly receive hover states

Restored :has() selector for truncate detection (line 645)

  • Changed from &[data-truncate='true'] back to &:has([data-truncate='true'])
  • The data-truncate attribute exists on child elements (<Truncate> component), not on ItemDescriptionWrap
  • Self-selector never matched, breaking truncation layout

Changelog

New

None

Changed

  • ActionList hover state selector now checks both [aria-disabled] and [data-disabled='true']
  • ActionList truncate selector uses :has() to detect truncated children

Removed

None

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

All ActionList and Item unit tests pass. VRT tests should now pass with correct selector matching.

Merge checklist


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI self-assigned this Dec 13, 2025
@changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2025

⚠️ No Changeset found

Latest commit: b975951

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI changed the title [WIP] Optimize costly css selectors fix(ActionList): restore aria-disabled and data-truncate selectors for VRT compatibility Dec 13, 2025
Copilot AI requested a review from mattcosta7 December 13, 2025 23:18
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 14, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants