Skip to content

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Oct 10, 2025

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@siddharthkp siddharthkp self-assigned this Oct 10, 2025
@siddharthkp siddharthkp requested a review from a team as a code owner October 10, 2025 10:57
@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Oct 10, 2025
Copy link

changeset-bot bot commented Oct 10, 2025

⚠️ No Changeset found

Latest commit: 61165e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a flaky visual regression test for the IconButton component by adding a small timeout to ensure stable screenshots. The test was failing intermittently after a previous change, likely due to timing issues with tooltip display animations.

  • Adds a 100ms timeout after tooltip becomes visible to ensure screenshot stability
  • Reformats existing waitFor call for consistency
  • Includes ESLint disable comment for the timeout usage

@github-actions github-actions bot added the staff Author is a staff member label Oct 10, 2025
@siddharthkp siddharthkp marked this pull request as draft October 10, 2025 11:08
Increased wait time for tooltip delay to ensure stable screenshots.
@siddharthkp siddharthkp added this pull request to the merge queue Oct 10, 2025
Merged via the queue into main with commit c7a6473 Oct 10, 2025
61 of 62 checks passed
@siddharthkp siddharthkp deleted the iconbutton-fix-flaky-visual-test branch October 10, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants