Skip to content

Conversation

pksjce
Copy link
Contributor

@pksjce pksjce commented Oct 7, 2025

Working on https://github.com/github/primer/issues/5713

  • Install @floating-ui/dom
  • Use method computePosition to replace getAnchorPosition

@pksjce pksjce self-assigned this Oct 7, 2025
Copy link

changeset-bot bot commented Oct 7, 2025

🦋 Changeset detected

Latest commit: 5d4b736

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Patch
@primer/styled-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 7, 2025
Copy link
Contributor

github-actions bot commented Oct 7, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@pksjce pksjce added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 7, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6957 October 7, 2025 04:02 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 7, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6957 October 7, 2025 04:14 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6957 October 7, 2025 04:23 Inactive
@pksjce pksjce added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 7, 2025
@github-actions github-actions bot requested a deployment to storybook-preview-6957 October 7, 2025 04:40 Abandoned
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 7, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6957 October 7, 2025 04:49 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6957 October 7, 2025 04:57 Inactive
Updated package versioning for @primer/react and replaced floating-ui for getAnchorPosition.
@pksjce pksjce added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 7, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6957 October 7, 2025 05:53 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 7, 2025
@github-actions github-actions bot requested a deployment to storybook-preview-6957 October 7, 2025 06:00 Abandoned
@primer-integration
Copy link

🔴 ci completed with status failure.

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 7, 2025
@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/4160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: failing Changes in this PR cause breaking changes in gh/gh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant