Skip to content

Conversation

hectahertz
Copy link
Contributor

@hectahertz hectahertz commented Sep 5, 2025

Closes https://github.com/github/primer/issues/5440

This pull request removes the deprecated SelectPanel2 component and all related files, stories, styles, and documentation from the codebase. It also updates references to its mock data in other story files and cleans up exports that previously included SelectPanel2 types and components.

Changelog

New

Changed/Removed

Component removal and cleanup:

  • Deleted the entire SelectPanel2 component and its documentation file (SelectPanel.docs.json), removing all code, props, and subcomponent definitions.
  • Removed all story files and story-specific CSS for SelectPanel2, including SelectPanel.stories.tsx, SelectPanel.playground.stories.tsx, SelectPanel.features.stories.module.css, and SelectPanel.module.css.

Exports and usage cleanup:

  • Removed SelectPanel and its related types from the exports snapshot to ensure they are no longer part of the public API.
  • Removed import of mockData from SelectPanel2 in ActionBar.examples.stories.tsx and replaced its usage with a hardcoded value to eliminate dependency on the deleted component.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@Copilot Copilot AI review requested due to automatic review settings September 5, 2025 13:42
@hectahertz hectahertz requested a review from a team as a code owner September 5, 2025 13:42
Copy link

changeset-bot bot commented Sep 5, 2025

🦋 Changeset detected

Latest commit: 7a01dc4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated SelectPanel2 experimental component from the Primer React codebase. The component was previously deprecated and is now being completely removed as part of a major version release.

  • Removes all SelectPanel2 component files, including implementation, tests, stories, and documentation
  • Cleans up exports to remove SelectPanel types from the public API
  • Updates dependent story files to remove references to deleted mock data

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

File Description
packages/react/src/experimental/index.ts Removes export of SelectPanel2 from experimental package
packages/react/src/__tests__/__snapshots__/exports.test.ts.snap Updates exports snapshot to remove SelectPanel types from public API
packages/react/src/ActionBar/ActionBar.examples.stories.tsx Replaces SelectPanel2 mock data import with hardcoded value

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 5, 2025
Copy link
Contributor

github-actions bot commented Sep 5, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@hectahertz hectahertz added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Sep 5, 2025
Copy link
Contributor

github-actions bot commented Sep 5, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 87.97 KB (0%)
packages/react/dist/browser.umd.js 88.08 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-6731 September 5, 2025 13:52 Inactive
@francinelucca francinelucca marked this pull request as draft September 5, 2025 19:06
@francinelucca francinelucca removed their request for review September 5, 2025 19:06
@hectahertz hectahertz marked this pull request as ready for review September 8, 2025 14:20
Copy link
Contributor

github-actions bot commented Sep 8, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 8, 2025
@github-actions github-actions bot requested a deployment to storybook-preview-6731 September 8, 2025 14:23 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6731 September 8, 2025 14:34 Inactive
@github-actions github-actions bot requested a deployment to storybook-preview-6731 September 8, 2025 15:27 Abandoned
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal code LGTM, what's the plan to get integration passing?


export const ActionbarToggle = () => {
const loginName = mockData.collaborators[1].login
const loginName = 'francinelucca'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm update snapshots 🤖 Command that updates VRT snapshots on the pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants