-
Notifications
You must be signed in to change notification settings - Fork 638
Remove the deprecated SelectPanel
experimental component
#6731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 7a01dc4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated SelectPanel2
experimental component from the Primer React codebase. The component was previously deprecated and is now being completely removed as part of a major version release.
- Removes all
SelectPanel2
component files, including implementation, tests, stories, and documentation - Cleans up exports to remove
SelectPanel
types from the public API - Updates dependent story files to remove references to deleted mock data
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/react/src/experimental/index.ts |
Removes export of SelectPanel2 from experimental package |
packages/react/src/__tests__/__snapshots__/exports.test.ts.snap |
Updates exports snapshot to remove SelectPanel types from public API |
packages/react/src/ActionBar/ActionBar.examples.stories.tsx |
Replaces SelectPanel2 mock data import with hardcoded value |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removal code LGTM, what's the plan to get integration passing?
|
||
export const ActionbarToggle = () => { | ||
const loginName = mockData.collaborators[1].login | ||
const loginName = 'francinelucca' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💅
Closes https://github.com/github/primer/issues/5440
This pull request removes the deprecated
SelectPanel2
component and all related files, stories, styles, and documentation from the codebase. It also updates references to its mock data in other story files and cleans up exports that previously includedSelectPanel2
types and components.Changelog
New
Changed/Removed
Component removal and cleanup:
SelectPanel2
component and its documentation file (SelectPanel.docs.json
), removing all code, props, and subcomponent definitions.SelectPanel2
, includingSelectPanel.stories.tsx
,SelectPanel.playground.stories.tsx
,SelectPanel.features.stories.module.css
, andSelectPanel.module.css
.Exports and usage cleanup:
SelectPanel
and its related types from the exports snapshot to ensure they are no longer part of the public API.mockData
fromSelectPanel2
inActionBar.examples.stories.tsx
and replaced its usage with a hardcoded value to eliminate dependency on the deleted component.Rollout strategy
Testing & Reviewing
Merge checklist