Skip to content

docs: add style guide docs #5987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

docs: add style guide docs #5987

wants to merge 5 commits into from

Conversation

joshblack
Copy link
Member

Add initial style guide based off of: #5805

Figured this was enough to get started, we can add more over time 👀

Let me know what you all thinks!

Copy link

changeset-bot bot commented Apr 30, 2025

⚠️ No Changeset found

Latest commit: d3e5add

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added the skip changeset This change does not need a changelog label Apr 30, 2025
@github-actions github-actions bot added the staff Author is a staff member label Apr 30, 2025
@joshblack joshblack marked this pull request as ready for review April 30, 2025 19:26
@Copilot Copilot AI review requested due to automatic review settings April 30, 2025 19:26
@joshblack joshblack requested a review from a team as a code owner April 30, 2025 19:26
@joshblack joshblack requested a review from francinelucca April 30, 2025 19:26
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Copy link
Contributor

github-actions bot commented Apr 30, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.94 KB (0%)
packages/react/dist/browser.umd.js 99.08 KB (0%)

@github-actions github-actions bot requested a deployment to storybook-preview-5987 April 30, 2025 19:29 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-5987 April 30, 2025 19:44 Inactive
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! some comments/suggestions

Comment on lines +160 to +174
<table>
<thead><tr><th>Unpreferred</th><th>Preferred</th></tr></thead>
<tbody>
<tr><td>

```tsx
type Props = {}
```

</td><td>

```tsx
type Props = {
fullWidth?: boolean
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get this example 😅

joshblack and others added 2 commits May 1, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants