-
Notifications
You must be signed in to change notification settings - Fork 608
docs: add style guide docs #5987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! some comments/suggestions
<table> | ||
<thead><tr><th>Unpreferred</th><th>Preferred</th></tr></thead> | ||
<tbody> | ||
<tr><td> | ||
|
||
```tsx | ||
type Props = {} | ||
``` | ||
|
||
</td><td> | ||
|
||
```tsx | ||
type Props = { | ||
fullWidth?: boolean | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get this example 😅
Co-authored-by: Marie Lucca <[email protected]>
Co-authored-by: Marie Lucca <[email protected]>
Add initial style guide based off of: #5805
Figured this was enough to get started, we can add more over time 👀
Let me know what you all thinks!