-
Notifications
You must be signed in to change notification settings - Fork 608
SelectPanel: Enable modern ActionList
FF by default in Storybook
#5938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ult for Storybook
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables the modern ActionList feature flag for the SelectPanel component in Storybook and fixes a typo in the flag name.
- Enables the feature flag 'primer_react_select_panel_with_modern_action_list' by default in the SelectPanel component.
- Updates the Storybook preview to use the same accurate feature flag.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/react/src/SelectPanel/SelectPanel.tsx | Updates the feature flag reference to use the correct flag name. |
packages/react/.storybook/preview.jsx | Aligns the feature flag in the Storybook decorators with the updated flag name. |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes please — Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
longshot but is there anyway to still keep vrt for non-modern version? 👀
I'd like to make sure we continue to support both until we're ready to remove the FF and the VRTs are a nice gut check.
Also can you clarify why primer_react_action_list_item_as_button
is no longer needed to be default on? 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also let's make sure to spot test the announcements with FF on/off since there was a typo in the name
Good point! Let me look to see if there's a way 👀 |
This is a FF we need to remove since the functionality is now bundled up in the ActionList CSS modules GA FF. |
Enables the
primer_react_select_panel_with_modern_action_list
feature flag by default for Storybook stories.Changelog
Changed
primer_react_select_panel_with_modern_action_list
by default in StorybookRollout strategy
Testing & Reviewing
Merge checklist