Skip to content

Conversation

@mperrotti
Copy link
Contributor

@mperrotti mperrotti commented Dec 10, 2024

Closes no issue created

As I was adding examples for the new Primer docs, I noticed that our SelectPanel stories didn't align with our a11y guidance or design guidelines.

I made the following updates:

  • Sort selected items to the top
  • Do not hide selected items when filtering with the text input
  • Make sure every select panel anchor has a label
  • Add example for a visually hidden label
  • Add example for a label that is rendered inside the button

Changelog

New

Nothing

Changed

Updated Storybook stories to better align with a11y and design guidelines

Removed

Nothing

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why
    • These changes only affect Storybook and VRTs, so they don't require a release

Testing & Reviewing

Confirm that stories still behave as expected.

Merge checklist

@mperrotti mperrotti added the skip changeset This change does not need a changelog label Dec 10, 2024
@mperrotti mperrotti requested a review from a team as a code owner December 10, 2024 21:41
@mperrotti mperrotti requested a review from langermank December 10, 2024 21:41
@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2024

⚠️ No Changeset found

Latest commit: aac9ae6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mperrotti mperrotti added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 10, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5407 December 10, 2024 21:46 Inactive
@primer primer bot requested a review from a team as a code owner December 10, 2024 21:54
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 10, 2024
@primer primer bot temporarily deployed to github-pages December 10, 2024 21:56 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5407 December 10, 2024 21:56 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.55 KB (0%)
packages/react/dist/browser.umd.js 102.86 KB (0%)

@mperrotti mperrotti added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Dec 10, 2024
@mperrotti mperrotti added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 10, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5407 December 10, 2024 23:29 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 10, 2024
@mperrotti mperrotti added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 5e0deac Dec 11, 2024
42 checks passed
@mperrotti mperrotti deleted the mp/selectpanel-story-fixes branch December 11, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants