Skip to content

Fix SelectPanel feature story #5406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
langermank merged 2 commits into from
Dec 10, 2024
Merged

Fix SelectPanel feature story #5406

langermank merged 2 commits into from
Dec 10, 2024

Conversation

@langermank
Copy link
Contributor

@langermank langermank commented Dec 10, 2024

The variant should never be full for SelectPanel.

@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 575c9d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@langermank langermank added skip changeset This change does not need a changelog update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Dec 10, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5406 December 10, 2024 19:31 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.51 KB (0%)
packages/react/dist/browser.umd.js 102.98 KB (0%)

@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 10, 2024
@langermank langermank marked this pull request as ready for review December 10, 2024 19:40
@langermank langermank requested review from a team as code owners December 10, 2024 19:40
@langermank langermank added this pull request to the merge queue Dec 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 10, 2024
@langermank langermank added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 8642c60 Dec 10, 2024
42 checks passed
@langermank langermank deleted the fix-selectpanel-variant branch December 10, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilybrick emilybrick Awaiting requested review from emilybrick emilybrick is a code owner automatically assigned from primer/design-reviewers

@TylerJDev TylerJDev Awaiting requested review from TylerJDev TylerJDev is a code owner automatically assigned from primer/engineer-reviewers

1 more reviewer

@mperrotti mperrotti mperrotti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@langermank @mperrotti