Skip to content

Conversation

@joshblack
Copy link
Member

@joshblack joshblack commented Dec 4, 2024

Remove the consumer-test workspace and corresponding workflow as I believe it's no longer needed (but let me know if that's not true 👀).

Since we have different examples now in the project, we should catch if TypeScript is not configured correctly for our package.

Changelog

New

Changed

Removed

  • Remove the consumer-test workspace in favor of testing our examples directly

Rollout strategy

  • None; if selected, include a brief description as to why
    reviews) section of the contributing guidelines for more information on how we review PRs. -->

This is a change internal to our project where we are removing a private workspace.

@joshblack joshblack requested a review from a team as a code owner December 4, 2024 17:25
@changeset-bot
Copy link

changeset-bot bot commented Dec 4, 2024

⚠️ No Changeset found

Latest commit: 412a26d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.3 KB (0%)
packages/react/dist/browser.umd.js 104.59 KB (0%)

@joshblack joshblack added skip changeset This change does not need a changelog and removed skip changeset This change does not need a changelog labels Dec 4, 2024
@joshblack joshblack added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 9885564 Dec 4, 2024
52 of 54 checks passed
@joshblack joshblack deleted the chore/remove-consumer-test-example branch December 4, 2024 20:32
francinelucca added a commit that referenced this pull request Dec 5, 2024
francinelucca added a commit that referenced this pull request Dec 5, 2024
francinelucca added a commit that referenced this pull request Dec 5, 2024
francinelucca added a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants