Skip to content

Conversation

@hussam-i-am
Copy link
Contributor

Changelog

New

Changed

  • Adds dev stories for SelectPanel
  • Adds SelectPanel dev stories to vrt test suite
  • Adds SelectPanel2 features to vrt test suite

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Test updates, nothing to rollout

Testing & Reviewing

Merge checklist

@hussam-i-am hussam-i-am self-assigned this Nov 21, 2024
@hussam-i-am hussam-i-am requested a review from a team as a code owner November 21, 2024 18:16
@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: a39852b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 101.27 KB (+0.05% 🔺)
packages/react/dist/browser.umd.js 101.63 KB (+0.18% 🔺)

@hussam-i-am hussam-i-am added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 21, 2024
@primer primer bot requested a review from a team as a code owner November 21, 2024 18:38
@primer primer bot requested a review from emilybrick November 21, 2024 18:38
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 21, 2024
@primer primer bot temporarily deployed to github-pages November 21, 2024 18:40 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5322 November 21, 2024 18:40 Inactive
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 21, 2024
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5322 November 21, 2024 19:02 Inactive
@hussam-i-am hussam-i-am added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 21, 2024
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 21, 2024
@primer primer bot temporarily deployed to github-pages November 21, 2024 19:41 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5322 November 21, 2024 19:42 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5322 November 21, 2024 20:11 Inactive
@hussam-i-am hussam-i-am added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 21, 2024
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 21, 2024
@primer primer bot temporarily deployed to github-pages November 21, 2024 20:35 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5322 November 21, 2024 20:36 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5322 November 21, 2024 21:38 Inactive
@hussam-i-am hussam-i-am added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 21, 2024
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/352188

@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 21, 2024
@hussam-i-am hussam-i-am added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 82c7923 Nov 21, 2024
41 of 42 checks passed
@hussam-i-am hussam-i-am deleted the hussam-i-am/select-panel-dev-stories branch November 21, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: failing Changes in this PR cause breaking changes in gh/gh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants