Skip to content

Conversation

@broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Mar 8, 2024

Closes #4129

Changelog

New

Changed

  • With this PR, we are wrapping button group items with a div. The main reason is to simplify CSS selection. You can view the previous attempt to write a CSS to fix styling issues both for tooltip v1 and v2 on button group.
  • Enhanced CSS selection for the ButtonGroup children elements to ensure buttons and links still look the same if there are tooltips on them

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@broccolinisoup broccolinisoup added the skip changeset This change does not need a changelog label Mar 8, 2024
@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2024

⚠️ No Changeset found

Latest commit: ea8b026

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot temporarily deployed to storybook-preview-4371 March 8, 2024 02:34 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 91.23 KB (-0.03% 🔽)
packages/react/dist/browser.umd.js 91.48 KB (-0.03% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-4371 March 8, 2024 05:05 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4371 April 5, 2024 02:52 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4371 May 8, 2024 00:09 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4371 May 27, 2024 01:06 Inactive
@primer-integration
Copy link

primer-integration bot commented Jul 1, 2024

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/331337

@broccolinisoup broccolinisoup changed the title Explore wrapping button group items with a div to simplify css selection ButtonGroup: Fix button and icon button styling when tooltips are used on them Jul 3, 2024
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 3, 2024
@primer primer bot temporarily deployed to github-pages July 3, 2024 03:08 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4371 July 3, 2024 03:08 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4371 July 3, 2024 23:46 Inactive
@broccolinisoup broccolinisoup added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 4, 2024
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 4, 2024
@primer primer bot temporarily deployed to github-pages July 4, 2024 05:32 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4371 July 4, 2024 05:33 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4371 July 4, 2024 23:44 Inactive
@broccolinisoup broccolinisoup added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 5, 2024
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 5, 2024
@primer primer bot temporarily deployed to github-pages July 5, 2024 01:08 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4371 July 5, 2024 01:08 Inactive
@broccolinisoup
Copy link
Member Author

closing in favour of #4723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using <Tooltip> within <ButtonGroup> affects styling

2 participants