-
Notifications
You must be signed in to change notification settings - Fork 10
Continue ESLint upgrade to V9 #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aprendendofelipe
wants to merge
14
commits into
primer:main
Choose a base branch
from
aprendendofelipe:eslint-v9
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9b47a4d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
c2bea41
to
d80c392
Compare
d80c392
to
f814094
Compare
Updated the PR description with the latest info. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request attempts to complete the work started in #287
🔍 You can view the relevant diff between the last commit of that PR and this one here:
Compare 51db88...f81409
An experimental version of the updated package is available on npm:
https://www.npmjs.com/package/@tabnews/eslint-plugin-primer-react
Note: The last commit fixes the name of a file so it can be picked up by the test suite (
.js
→.test.js
).Updates
eslint-plugin-github
tov6.0.0
and used themjs
extension ineslint.config
, but reverted back tov5.1.8
so compatibility can be handled in a separate PR.README.md
with an example of flat config usage.getFlatConfigs()
.