fix: Performance issue for TreeSelect component

[sinkersan]

Fixes #6950
You can read a detailed explanation in the issue.

Here’s how I measured performance for the current version:

selectedNodes() {
  let selectedNodes = [];
  
  if (this.d_value && this.options) {
      let keys = { ...this.d_value };
      
      performance.mark('findSelectedNodesStart');
  
      this.findSelectedNodes(null, keys, selectedNodes);
  
      performance.mark('findSelectedNodesEnd');
  
      const perfResult = performance.measure('findSelectedNodesDuration', 'findSelectedNodesStart', 'findSelectedNodesEnd');
  
      console.log(`findSelectedNodes duration: ${perfResult.duration}`);
  }
  
  return selectedNodes;
        }

And here’s how I measure it for my solution:

nodeMap() {
    const nodeMap = {};

    performance.mark('nodeMapStart');

    this.options?.forEach(node => this.fillNodeMap(node, nodeMap))

    performance.mark('nodeMapEnd');

    const perfResult = performance.measure('nodeMapDuration', 'nodeMapStart', 'nodeMapEnd');

    console.log(`nodeMap duration: ${perfResult.duration}`);

    return nodeMap;
},

In both cases, execution time was captured exactly for the recursive function, so I consider it proof.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

Name	Status	Preview	Updated (UTC)
primevue	⬜️ Ignored (Inspect)	Visit Preview	Dec 11, 2024 10:23pm
primevue-v3	⬜️ Ignored (Inspect)	Visit Preview	Dec 11, 2024 10:23pm

[sinkersan]

I’ve also noticed that the current version doubles nodes in the selectedNodes computed property for some reason.

My version doesn’t have this behavior.

I think this is good. Correct me if I’m wrong.

Still, I think it’s better to use a cached object instead of calculating the data every time the user interacts with the component.

Feel free to provide any feedback.