Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toast): make on hover sticky until stop hovering #5131

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

patroza
Copy link

@patroza patroza commented Jan 23, 2024

As discussed on Discord, in my experience, Toasts should remain open while hovering on them, even when they have a timeout.
This PR addresses that requirement.

Copy link

vercel bot commented Jan 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2024 8:19am

@patroza patroza marked this pull request as ready for review January 23, 2024 14:52
@patroza patroza changed the title feat: make toast on hover sticky until stop hovering feat(toast): make on hover sticky until stop hovering Jan 24, 2024
@tugcekucukoglu tugcekucukoglu added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jan 24, 2024
@ZiadJ
Copy link

ZiadJ commented Aug 2, 2024

Any reason why this is taking so long to merge? I'm asking because it's more or less the default behavior for toasts these days. The user might need time to read the message or press on a button so being able to hover the toast to delay things wold be quite helpful. It also helps when one needs to copy and paste text from the toast.

@patroza
Copy link
Author

patroza commented Aug 2, 2024

Any reason why this is taking so long to merge?

you tell me, it's certainly one of those situations that spoil OSS.

@alverbitskiy
Copy link

@patroza thank you for your work! Much appreciated!
@tugcekucukoglu is there a chance to look at this PR? This functionality is sorely needed for exactly the reason described by ZiadJ in the second message, in our project our team is in discussion on how to work around it without having to create a modified version of the component, this PR would have solved this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants