Skip to content

Conversation

KumJungMin
Copy link
Contributor

@KumJungMin KumJungMin commented Nov 23, 2024

Defect Fixes


How to Resolve?

  • <AutoComplete /> has two issue
    • (1) iconPosition props warning
    • (2) iconPostion is not working

issue(1): iconPosition props warning

  • when using <IconField /> and set iconPosition, the iconPosition props warning emeraged in<AutoComplete />.
  • for fix this warning, I added IconPosition in defaultProps of AutoComplete component.

issue(2): iconPostion is not working

  • the iconPosition is working in <InputText />, but not working in <AutoComplete/>.
  • because, the icon-field style is not applied in p-autocomplete
  • for fix this issue, I updated 'primereact-sass-theme' theme(PR link)
before after
스크린샷 2024-11-23 오후 10 30 50 스크린샷 2024-11-23 오후 10 29 54

Copy link

vercel bot commented Nov 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 1:56pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 1:56pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning: React does not recognize the iconPosition prop on a DOM element. (v10.8.3)
3 participants