Skip to content

Replace hacks that worked on old versions of xarray with proper xarray calls #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

mikapfl
Copy link
Member

@mikapfl mikapfl commented Mar 23, 2022

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Description in a .rst file in the directory changelog_unreleased added - remember to include a * to make it a bullet point

Description

The latest (not-yet-released) version of xarray contains a rework of indexing and some small changes to our I/O functions are necessary to support both old and new xarray.

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.26%. Comparing base (472f94d) to head (7f06ffc).
Report is 563 commits behind head on main.

Files Patch % Lines
primap2/pm2io/_interchange_format.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   97.30%   97.26%   -0.04%     
==========================================
  Files          32       32              
  Lines        2889     2891       +2     
==========================================
+ Hits         2811     2812       +1     
- Misses         78       79       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikapfl mikapfl merged commit e7b87d6 into primap-community:main Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant