[Project1/최민석] Colors #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datalater
reviewed
Sep 14, 2021
| $main.className = "main-container"; | ||
| $target.appendChild($main); | ||
|
|
||
| let ColorListIndex = 0; |
There was a problem hiding this comment.
사소한 부분이지만 자바스크립트 변수 네이밍 컨벤션은 camelCase니까 colorListIndex로 하면 어떨까요?ㅎㅎ
Comment on lines
+34
to
+36
| if (ColorListIndex > COLOR_LIST.length - 1) { | ||
| ColorListIndex = 0; | ||
| } |
There was a problem hiding this comment.
고양이 사진 검색기에서도 나왔던 패턴이군요! 저는 랜덤 컬러를 랜덤으로 만드는 것으로 구현했는데 민석님은 원본 프로젝트를 꼼꼼히 살펴보시고 정해진 패턴대로 움직인다는 것을 파악하셨네요 👍👍👍
Comment on lines
+1
to
+2
| import App from "./components/App.js"; | ||
| const $app = document.querySelector("#App"); |
There was a problem hiding this comment.
eslint에서는 import 라인 뒤에 new line을 넣도록 권장하고 있는데 한번 참고하시면 좋을 것 같습니다ㅎㅎ
Comment on lines
+34
to
+41
| @keyframes colorChange { | ||
| from { | ||
| color: #000000; | ||
| } | ||
| to { | ||
| color: #ffffff; | ||
| } | ||
| } |
There was a problem hiding this comment.
저는 setInterval로 구현했는데 역시 CSS잘알이셔서 애니메이션을 활용하셨군요!! 배워갑니다👍👍👍
Comment on lines
+7
to
+8
| <link rel="stylesheet" href="./assets/reset.css" /> | ||
| <link rel="stylesheet" href="./assets/index.css" /> |
There was a problem hiding this comment.
전에 동영팀 스크럼때 reset.css 말씀해주셨던 것 같은데 이렇게 활용하는 거군요ㅎㅎ배워갑니다👍
| const secondColor = randHexColorCode(); | ||
| const nextBackgroundColor = `background: linear-gradient(to right, ${firstColor}, ${secondColor});`; | ||
| colorText.setState({ firstColor, secondColor }); | ||
| $main.style = nextBackgroundColor; |
There was a problem hiding this comment.
$main의 스타일을 고치는 부분도 setState로 처리해볼 수 있을 것 같은데 어떻게 생각하시나요?$main의 스타일(style) 객체 전체를nextBackgroundColor로 할당하는 것보다style.background = linear-gradient(to right, ...)와 같이 해당하는 것만 바꾸는 게 안전할 것 같다는 생각이 듭니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.