ISO8601 timestamp support #2
Conversation
Empty string is deseralized as null timestamp
|
@gszjulcsi Please, review it. |
There was a problem hiding this comment.
Wow, intellij seesm to reformatted and removed the extra space.
There was a problem hiding this comment.
:)
On Thu, Apr 9, 2015 at 2:21 PM, treff7es [email protected] wrote:
In
json-serde/src/test/java/org/openx/data/jsonserde/JsonSerDeTimeStampTest.java
#2 (comment):@@ -91,7 +91,7 @@ public void testTimestampDeSerializeNumericTimestamp() throws Exception {
StructObjectInspector soi = (StructObjectInspector) instance.getObjectInspector();
JavaStringTimestampObjectInspector jstOi = (JavaStringTimestampObjectInspector)
soi.getStructFieldRef("five").getFieldObjectInspector();
- assertEquals(getDate("2013-05-05 17:58:45.0" ),
- assertEquals(getDate("2013-05-05 17:58:45.0"),
Wow, intellij seesm to reformatted and removed the extra space.
—
Reply to this email directly or view it on GitHub
https://github.com/prezi/Hive-JSON-Serde/pull/2/files#r28056549.
|
ok, it looks good. |
-Applying the ISO8601 support from pull request rcongiu#88 - - --Empty string is deseralized as null timestamp