Skip to content

fix: exclude .ts and .tsx as xml extensions #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Jun 23, 2025

No description provided.

@kddnewton kddnewton merged commit 388e123 into prettier:main Jun 23, 2025
2 checks passed
@JounQin JounQin deleted the fix/ts_extensions branch June 23, 2025 14:15
@JounQin
Copy link
Member Author

JounQin commented Jun 24, 2025

@kddnewton When will this PR be released?

@Tatsh
Copy link

Tatsh commented Jun 25, 2025

Does this change break overrides configuration? I can see myself wanting to format Qt translation files with this plugin in the future.

I actually ran into the issue this aims to resolve but now I am thinking this may not be the best solution. I think we may have to live with it though due to the design of Prettier and how it chooses parsers.

@JounQin
Copy link
Member Author

JounQin commented Jun 25, 2025

@Tatsh User's own overrides always takes higher priority now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants