-
Notifications
You must be signed in to change notification settings - Fork 5.5k
docs(native): Add documentation for Presto C++ Installation #26718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
docs(native): Add documentation for Presto C++ Installation #26718
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds new Sphinx documentation describing how to install and run the Presto C++ worker, including build, configuration, and integration steps, by introducing a dedicated installation guide and wiring it into the existing Presto C++ docs hierarchy. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Since you’ve moved content under
presto_cpp/installation.rst, make surepresto-cpp.rst(and any relevant toctrees) links to this new doc so it’s discoverable from the main navigation. - Check for any existing references or deep links to
presto-cpp.rstthat should now point to the newpresto_cpp/installation.rstpath to avoid broken links in the published docs.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since you’ve moved content under `presto_cpp/installation.rst`, make sure `presto-cpp.rst` (and any relevant toctrees) links to this new doc so it’s discoverable from the main navigation.
- Check for any existing references or deep links to `presto-cpp.rst` that should now point to the new `presto_cpp/installation.rst` path to avoid broken links in the published docs.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Description
Added new documentation explaining how to use the Presto C++ engine.
The documentation provides step-by-step instructions for building, configuring, and running the Presto C++ worker##
Motivation and Context
There was no consolidated or beginner-friendly documentation for Presto C++ in the open-source project.
Users often had difficulty understanding how to build and run the C++ worker, what dependencies were required, and how it integrates with a Presto coordinator.
Impact
There is no performance impact.
Test Plan
Contributor checklist
Release Notes