Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilized Columns fix for views #24638

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kevintang2022
Copy link
Contributor

@kevintang2022 kevintang2022 commented Feb 26, 2025

Description

  • Perform the exploration of a view's definition just like how we would perform exploration of a subquery

Motivation and Context

T214103298
The user's dataswarm tasks is failing because the ACL is checking every column in the view table when it should only be checking ACL on the utilized columns

Impact

Test Plan

Added automated tests for queries involving views

Deploy to verifier cluster

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Utilized column exploration for view definitions 

@kevintang2022 kevintang2022 force-pushed the utlized-columns-fix-for-views branch from 31a3208 to 682f652 Compare February 27, 2025 17:03
@kevintang2022 kevintang2022 changed the title WIP Utilized Columns fix for views Feb 27, 2025
Update test file to check all utilized references

Add test for definer mode

Lint

Untab

Untab 2

Remove line break

Lint
@kevintang2022 kevintang2022 force-pushed the utlized-columns-fix-for-views branch from fd94abe to 6423cf4 Compare February 27, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant