Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Iceberg] Rename "target_split_size" to "target_split_size_bytes" #24618

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ZacBlanco
Copy link
Contributor

@ZacBlanco ZacBlanco commented Feb 24, 2025

Description

Renames the target split size property to make it clear that only a bytes value is accepted.

Motivation and Context

Less confusion

Impact

Renames a session property. This has not been in any release yet, so no serious impact. The original PR has had the release note updated with the correct name

Test Plan

N/A

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Feb 24, 2025
@ZacBlanco ZacBlanco marked this pull request as ready for review February 25, 2025 19:57
@ZacBlanco ZacBlanco requested review from hantangwangd and a team as code owners February 25, 2025 19:57
aaneja
aaneja previously approved these changes Feb 26, 2025
hantangwangd
hantangwangd previously approved these changes Feb 26, 2025
@ZacBlanco ZacBlanco dismissed stale reviews from hantangwangd and aaneja via 52112d8 February 26, 2025 17:13
@ZacBlanco ZacBlanco force-pushed the upstream-iceberg-split-size-prop-name branch from 3ac7dbf to 52112d8 Compare February 26, 2025 17:13
@ZacBlanco ZacBlanco force-pushed the upstream-iceberg-split-size-prop-name branch from 52112d8 to 12f419c Compare February 26, 2025 18:49
steveburnett
steveburnett previously approved these changes Feb 26, 2025
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull branch, local doc build, looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants