Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overflow detection to IntervalYearMonthOperators #24617

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pramodsatya
Copy link
Contributor

@pramodsatya pramodsatya commented Feb 24, 2025

Description

Part of #24087. Duplicate of #24089, continuing it here since Tim is OOO and this change is needed for Velox PR: facebookincubator/velox#11612.

Motivation and Context

Fix incorrect data caused by overflow, and correct the type mapping in certain operators.

Impact

Where previously some expressions could have resulted in an overflow and incorrect results, now they will fail with a NUMERIC_VALUE_OUT_OF_RANGE error.

Test Plan

Unit tests

Release Notes

== RELEASE NOTES ==

General Changes
* Fix addition, subtraction, multiplication and division of ``INTERVAL YEAR MONTH`` values.

@pramodsatya pramodsatya requested a review from a team as a code owner February 24, 2025 19:08
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Feb 24, 2025
@prestodb-ci prestodb-ci requested review from a team, ScrapCodes and psnv03 and removed request for a team February 24, 2025 19:08
@steveburnett
Copy link
Contributor

Thanks for the release note!

New release note guidelines. Please remove the manual PR link in the following format from the release note entries for this PR.


:pr:`12345`

I have updated the Release Notes Guidelines to remove the examples of manually adding the PR link.

@pramodsatya
Copy link
Contributor Author

Thanks @steveburnett, removed the manual PR link from release note. Could you please take another look?

@pramodsatya
Copy link
Contributor Author

@hantangwangd, could you please help review/merge this PR? The commit is cherrypicked from #24089 that you had helped review before. Thanks!

@steveburnett
Copy link
Contributor

Thanks @steveburnett, removed the manual PR link from release note. Could you please take another look?

LGTM! Thanks!

Copy link
Member

@hantangwangd hantangwangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@pramodsatya
Copy link
Contributor Author

@jaystarshot, @yingsu00, could you please help review this PR?

@majetideepak
Copy link
Collaborator

@jaystarshot Can you please help with this review? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants