Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for delta timestamp_ntz datatype #24418

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for delta timestamp_ntz datatype #24418

wants to merge 1 commit into from

Conversation

infvg
Copy link
Contributor

@infvg infvg commented Jan 23, 2025 •
edited
Loading

Description

Add support for TIMESTAMP_NTZ data type in v3 delta tables.
Currently, only TIMESTAMP column types are supported in presto.

Impact

Will allow presto to read tables with TIMESTAMP_NTZ columns

Test Plan

Added UT

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==
Delta Connector Changes
* Added support for ``TIMESTAMP_NTZ`` column type :pr:`24418`

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jan 23, 2025
@infvg infvg marked this pull request as ready for review January 23, 2025 11:18
@infvg infvg requested a review from a team as a code owner January 23, 2025 11:18
@infvg infvg requested a review from presto-oss January 23, 2025 11:18
@steveburnett
Copy link
Contributor

Thanks for the release note! Nits suggested:

== RELEASE NOTES ==

Delta Connector Changes
* Add support for ``TIMEZONE_NTZ`` column type. :pr:`24418`

imjalpreet
imjalpreet reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@imjalpreet imjalpreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refactor the commit message, PR title/description and Release note to timestampNTZ rather than timezoneNTZ.

@imjalpreet imjalpreet mentioned this pull request Jan 23, 2025
Open
@infvg infvg changed the title Add support for delta timezone_ntz datatype Add support for delta timestamp_ntz datatype Jan 27, 2025
@infvg infvg force-pushed the delta-timentz-support branch from c6371a6 to fb5fef3 Compare January 27, 2025 09:03
agrawalreetika
agrawalreetika reviewed Jan 27, 2025
View reviewed changes
presto-delta/src/test/java/com/facebook/presto/delta/TestDeltaIntegration.java Outdated
PATH_SCHEMA, goldenTablePathWithPrefix(version, "test-typing"));
MaterializedResult expectedResult = getQueryRunner().execute(testQuery);
assertEquals(expectedResult.getMaterializedRows().size(), 10);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add some queries and asset around checking timestamp_ntz column type on this table as well?

@infvg
Add support for delta timestamp_ntz datatype
bd1117e 
Add support for TIMESTAMP_NTZ datatype columns in v3 delta tables.
@infvg infvg force-pushed the delta-timentz-support branch from fb5fef3 to bd1117e Compare January 29, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrawalreetika agrawalreetika agrawalreetika left review comments

@imjalpreet imjalpreet imjalpreet left review comments

@presto-oss presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
from:IBM PR from IBM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@infvg @steveburnett @imjalpreet @agrawalreetika @prestodb-ci