Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Iceberg] Session property for target split size #24417

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ZacBlanco
Copy link
Contributor

@ZacBlanco ZacBlanco commented Jan 23, 2025

Description

Adds a session property for target split size.

Motivation and Context

Makes it easier to do performance debugging by setting the desired split size on a per-query basis.

Impact

New configuration property.

Test Plan

unit tests

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== RELEASE NOTES ==

Iceberg Connector Changes
* Add target_split_size session property :pr:`24417`

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jan 23, 2025
@steveburnett
Copy link
Contributor

Thanks for the release note! Nit formatting suggestion.

== RELEASE NOTES ==

Iceberg Connector Changes
* Add ``target_split_size session`` property. :pr:`24417`

Consider documenting the new session property, perhaps in
https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/connector/iceberg.rst#session-properties .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants