-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a wrapper for event loop to handle exceptions gracefully #24412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the release notes to indicate that this is a bug fix per our release notes guidelines
presto-main/src/main/java/com/facebook/presto/server/remotetask/HttpRemoteTask.java
Outdated
Show resolved
Hide resolved
c9a62af
to
f8ee70f
Compare
eef6836
to
503a60e
Compare
503a60e
to
a6e0424
Compare
presto-main/src/main/java/com/facebook/presto/server/remotetask/HttpRemoteTaskFactory.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tricky bug. Didn't expect the implementation to be not exception safe. It used to be that some executors implementations in Java were not thread safe (e.g.: ScheduledExecutorService) but I remember it was fixed a while ago. Thank you for working on the fix.
presto-main/src/main/java/com/facebook/presto/server/remotetask/HttpRemoteTaskFactory.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/server/remotetask/HttpRemoteTaskFactory.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/server/remotetask/HttpRemoteTaskFactory.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/server/remotetask/HttpRemoteTask.java
Outdated
Show resolved
Hide resolved
8af244b
to
1cf4320
Compare
presto-main/src/main/java/com/facebook/presto/server/remotetask/HttpRemoteTaskFactory.java
Outdated
Show resolved
Hide resolved
1cf4320
to
d758c60
Compare
d758c60
to
70eae6c
Compare
Description
and thanks to @arhimondr, the root cause is if running code on event loop and the code throws exception, the event loop thread will be killed but the event loop group will not create a new thread.
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.