Skip to content

Commit

Permalink
refactor: Removes 5.0 approved legacy charts (apache#31582)
Browse files Browse the repository at this point in the history
  • Loading branch information
michael-s-molina authored Jan 9, 2025
1 parent a477d84 commit 399b709
Show file tree
Hide file tree
Showing 222 changed files with 1,128 additions and 12,359 deletions.
1 change: 1 addition & 0 deletions UPDATING.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ assists people when migrating to a new version.

## Next

- [31582](https://github.com/apache/superset/pull/31582) Removed the legacy Area, Bar, Event Flow, Heatmap, Histogram, Line, Sankey, and Sankey Loop charts. They were all automatically migrated to their ECharts counterparts with the exception of the Event Flow and Sankey Loop charts which were removed as they were not actively maintained and not widely used. If you were using the Event Flow or Sankey Loop charts, you will need to find an alternative solution.
- [31198](https://github.com/apache/superset/pull/31198) Disallows by default the use of the following ClickHouse functions: "version", "currentDatabase", "hostName".
- [29798](https://github.com/apache/superset/pull/29798) Since 3.1.0, the intial schedule for an alert or report was mistakenly offset by the specified timezone's relation to UTC. The initial schedule should now begin at the correct time.
- [30021](https://github.com/apache/superset/pull/30021) The `dev` layer in our Dockerfile no long includes firefox binaries, only Chromium to reduce bloat/docker-build-time.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,10 @@ describe('explore view', () => {
});

it('should load Explore', () => {
const LINE_CHART_DEFAULTS = { ...FORM_DATA_DEFAULTS, viz_type: 'line' };
const LINE_CHART_DEFAULTS = {
...FORM_DATA_DEFAULTS,
viz_type: 'echarts_timeseries_line',
};
const formData = { ...LINE_CHART_DEFAULTS, metrics: [NUM_METRIC] };
cy.visitChartByParams(formData);
cy.verifySliceSuccess({ waitAlias: '@getJson', chartSelector: 'svg' });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -524,8 +524,8 @@ describe('Drill by modal', () => {
]);
});

it('Bar Chart V2', () => {
testEchart('echarts_timeseries_bar', 'Bar Chart V2', [
it('Bar Chart', () => {
testEchart('echarts_timeseries_bar', 'Bar Chart', [
[70, 94],
[362, 68],
]);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -431,19 +431,6 @@ describe('Drill to detail modal', () => {
});
});
});

describe('Bar Chart', () => {
it('opens the modal for unsupported chart without filters', () => {
interceptSamples();

cy.get("[data-test-viz-type='dist_bar'] svg").then($canvas => {
cy.wrap($canvas).scrollIntoView();
cy.wrap($canvas).rightclick(70, 150);
openModalFromChartContext('Drill to detail');
cy.getBySel('filter-val').should('not.exist');
});
});
});
});

describe('Tier 2 charts', () => {
Expand Down
Loading

0 comments on commit 399b709

Please sign in to comment.