-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sqlglot dependency conflict with superset 4 and fix superset auth/reauth to use only the API #319
base: main
Are you sure you want to change the base?
Conversation
This reverts commit bd7c58d.
Extended superset client - users, reports
Changed package name, updated sqlglot dependency, added update_chart
Added Superset delete methods
Hi @Vitor-Avila! Sorry, I've missed your comment. I've bumped the
|
I've added the backend-sdk/src/preset_cli/cli/superset/sync/dbt/metrics.py Lines 126 to 135 in 86f5ad6
All tests are passing now. |
Hey @joaopamaral, Checking this PR, I can see the following changes:
I left some first pass comments, but I'm wondering if we should actually split this work into individual PRs? This would allow us to merge them individually as we make progress. It seems that the CLA signature also didn't reflect properly FYI. |
Hi @Vitor-Avila! Thanks for the review! |
No rush @joaopamaral. And thank YOU for these contributions. We really appreciate it 🙌 |
There is a conflict with superset 4 dependencies and using only the API to authenticate it's better than using web scraping tool to avoid unexpected issues when the UI changes.