Enconding improvements #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That is super interesting. I'll give it a test a bit later. Thanks for the work. |
|
Thank you for this. It works, and has been merged as part of 0697c8d. |
|
If you're wondering why I had to re-create the PR, it's because I released some other stuff which made merge conflicts in your branch. The quickest way to get your original work into the project was to rebase your work on this of that merge-inducing stuff. |
|
No worries. Thank you for the update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Testing the plugin on several libraries, I found that the
serializeencoding is not working for all cases.This is one the file that was generating the issue: https://github.com/illuminate/support/blob/v5.6.39/helpers.php
In this PR, I've improved the encoding with gzencode/gzdecode in the
parsemethod. To be consistent, I've also replaced it in thedefermethod.