Command line todo list #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
Short demo:
|
vlebedeff
reviewed
Jun 21, 2018
| desc "-a or --add [TASK]", "Adds an item into the list of tasks" | ||
| map %w[-a --add] => :add | ||
| def add(task) | ||
| @store.tasks = @store.tasks << task |
Collaborator
There was a problem hiding this comment.
Maybe provide add_task or something in the store object so that the UI layer is kept as think as possible
vlebedeff
reviewed
Jun 21, 2018
| return | ||
| end | ||
|
|
||
| shell.say "\n\"\e[1m#{tasks.delete_at(item.to_i - 1)}\"\e[0m [removed]\n\n" |
Collaborator
There was a problem hiding this comment.
Probably should separate the business logic from showing messages to user to make the presentation logic less invasive
Collaborator
There was a problem hiding this comment.
Also could be cool to provide some kind of helper that removes the noise from using color codes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command line todo list
Description
Write an command line application that helps you manage your tasks.
The information can be stored in any prefered way. The program should be launched from the console with different attributes: