-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for case
#260
Add support for case
#260
Conversation
Hi @wolfv, this is ready for the review! |
@kp992 - would you be able to add a few more test cases? Happy to merge then! |
@kp992 Thank you very much for the PR! |
@@ -0,0 +1,16 @@ | |||
fruit="apple" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you possibly include some tests where the patterns have the starting (
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, added some more test cases.
Do you think we could add support for using |
Sure, I can work on adding them in the new PR? This PR looks like a complete one with all the edge cases I found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks awesome!
Thank you very much!
Hi @wolfv,
I am trying to add support for
case
and have tried to add an initial logic. I will also try to add more test cases once the basics start working.