Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for case #260

Merged
merged 10 commits into from
Mar 25, 2025
Merged

Add support for case #260

merged 10 commits into from
Mar 25, 2025

Conversation

kp992
Copy link
Contributor

@kp992 kp992 commented Mar 18, 2025

Hi @wolfv,

I am trying to add support for case and have tried to add an initial logic. I will also try to add more test cases once the basics start working.

@kp992
Copy link
Contributor Author

kp992 commented Mar 20, 2025

Hi @wolfv, this is ready for the review!

@wolfv
Copy link
Member

wolfv commented Mar 22, 2025

@kp992 - would you be able to add a few more test cases? Happy to merge then!

@prsabahrami
Copy link
Contributor

@kp992 Thank you very much for the PR!
The PR looks amazing.
I think we might have to update the grammar however.
I was looking at the pattern and not sure why it contains Esac in the pattern itself. Do you think we need this?

@@ -0,0 +1,16 @@
fruit="apple"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you possibly include some tests where the patterns have the starting ( as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added some more test cases.

@prsabahrami
Copy link
Contributor

Do you think we could add support for using ;& or ;;& in place of ;; as well? We can definitely do this in another PR as well.

@kp992
Copy link
Contributor Author

kp992 commented Mar 25, 2025

Do you think we could add support for using ;& or ;;& in place of ;; as well? We can definitely do this in another PR as well.

Sure, I can work on adding them in the new PR? This PR looks like a complete one with all the edge cases I found.

Copy link
Contributor

@prsabahrami prsabahrami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks awesome!
Thank you very much!

@prsabahrami prsabahrami merged commit 1f2a18f into prefix-dev:main Mar 25, 2025
7 of 8 checks passed
@kp992 kp992 deleted the case_support branch March 25, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants