Dailymotion bid adapter: add ortb converter and floor price support #12784
Conversation
kvnsw
force-pushed
the
master
branch
2 times, most recently
from
2800d08 to
94465ad
Compare
|
@kvnsw looks like your unit tests are failing on this pr in one of the browsers on circleci |
|
Hey @ChrisHuie, thanks, I thought it was unrelated to our changes (considering the tests that are failing). I locally dropped our commit and re-ran the tests and am getting the same kind of errors 🤔 (see screenshot, 
Edit: Looks like other contributions are having the same issues (eg: #12785) |
|
@kvnsw your test failures are due to your changes and are unrelated to the iiq pr |
kvnsw
force-pushed
the
master
branch
2 times, most recently
from
2ed9c41 to
ab07eb1
Compare
| config.setConfig({ | ||
| userSync: { | ||
| syncEnabled: true, | ||
| filterSettings: { | ||
| image: { | ||
| bidders: ['dailymotion'], | ||
| filter: 'include' | ||
| }, | ||
| iframe: { | ||
| bidders: ['dailymotion'], | ||
| filter: 'exclude', | ||
| }, | ||
| } | ||
| } | ||
| }); |
There was a problem hiding this comment.
this should be in a setup block (before or beforeEach) and torn down with config.resetConfig().
As it is here (outside of any test case) it's executed before any test, so unless you run your suite in isolation it will interfere with tests that do not expect it, and by the time your tests run they won't necessarily see this configuration.
kvnsw
force-pushed
the
master
branch
2 times, most recently
from
9a57531 to
64cb2dc
Compare
|
Hello @dgirardi, @patmmccann, @ChrisHuie thank you for your reviews! |
Type of change
Description of change
Added support of oRTB & floor prices for Dailymotion Bid Adapter