New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed index.js 404 error issue , replaced string concatenation with ES6 Template Literals #42

Open

bhxlla wants to merge 1 commit into prateekkalra:master from bhxlla:master

bhxlla commented Aug 15, 2020 •

edited

Loading

Replaced String Concatenation with ES6 Template Literals for inline-styling,
Used DocumentFragment to append all the buttons inside .selection element for better performance.
Prevented the Selection Pop-up from Opening when a user clicks anywhere on the document and not select the text, When we double clicked on any empty space , it would open a pop-up with a '\n' character a text selected.
Added script link to index.js which doesn't exist in the root directory , hence showed the error on the console.
Removed additional count variable


           Fixed index.js 404 error issue , replaced string concatenation with …

8af09e3

…Es6 template literals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet