Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds swayosd #1818

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

TheyCallMeSecond
Copy link

Pull Request

Description

  • Replace SwayOSD with Custom OSD for volume and brightness

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

@rubiin rubiin mentioned this pull request Sep 9, 2024
16 tasks
Copy link
Contributor

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace the title with "feat: adds swayosd"

@TheyCallMeSecond TheyCallMeSecond changed the title Replace SwayOSD with Custom OSD for volume and brightness feat: adds swayosd Sep 9, 2024
@rubiin
Copy link
Contributor

rubiin commented Sep 10, 2024

@kRHYME7 LGTM

Copy link
Contributor

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also add show_percentage = true, latest build suports it

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Sep 12, 2024

I don't know if I can merge this. I won't even touch his keybindings, which uses the scripts .
Title is misleading we are not adding swayosd, but we are replacing Tittus configs now.

I will suggest making this an optional package (Not all is using chaotic-aur)

I can merge these only If I don't mess up his config. We can add a Markdown for extending HyDE capability, in which I am trying to do with Hyprpanel.

  • We can add this to restore_cfg.lst N|Y|${HOME}/.config/swayosd|config.toml | swayosd-git
  • add swayosd-git to custom_app.lst instead of custom_hypr.lst
  • for backlight and pulseaudio waybar modules we can all just add another module but with tags pulseaudio#swayosd.jsonc and backlight#swayosd.jsonc and users can add those #swayosd in the ./waybar./config.ctl` If we can provide theme a wiki.

Sorry, this might be an inconvenience, but the owner is always trying to lessen the repo's dependencies.

@rubiin
Copy link
Contributor

rubiin commented Sep 12, 2024

I checked hyprpanel. Looks good. It also has an osd , are we gonna switch from waybar to that? or will there be an option to choose

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Sep 12, 2024

No options on intallation yet but an extensive wiki for extension yes. (Hope so).

@TheyCallMeSecond
Copy link
Author

I don't know if I can merge this. I won't even touch his keybindings, which uses the scripts . Title is misleading we are not adding swayosd, but we are replacing Tittus configs now.

I will suggest making this an optional package (Not all is using chaotic-aur)

I can merge these only If I don't mess up his config. We can add a Markdown for extending HyDE capability, in which I am trying to do with Hyprpanel.

  • We can add this to restore_cfg.lst N|Y|${HOME}/.config/swayosd|config.toml | swayosd-git
  • add swayosd-git to custom_app.lst instead of custom_hypr.lst
  • for backlight and pulseaudio waybar modules we can all just add another module but with tags pulseaudio#swayosd.jsonc and backlight#swayosd.jsonc and users can add those #swayosd in the ./waybar./config.ctl` If we can provide theme a wiki.

Sorry, this might be an inconvenience, but the owner is always trying to lessen the repo's dependencies.

i changed that things you said except pulseaudio#swayosd.jsonc and backlight#swayosd.jsonc...i think if anyone choose to use swayosd doesnt need custom osd anymore

i tested HyprPanel today...it works fine but have some minor bugs yet
image

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Sep 13, 2024

i changed that things you said except pulseaudio#swayosd.jsonc and backlight#swayosd.jsonc...i think if anyone choose to use swayosd doesnt need custom osd anymore

How about leaving the pulseaudio and backlight as is and make a separate module for swayosd?

@TheyCallMeSecond
Copy link
Author

i changed that things you said except pulseaudio#swayosd.jsonc and backlight#swayosd.jsonc...i think if anyone choose to use swayosd doesnt need custom osd anymore

How about leaving the pulseaudio and backlight as is and make a separate module for swayosd?

i understand what you say and why...i will work on it in this weekend and if you have any idea to how separate this two configs well pls share with us because we have conflict with keybindings too

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Sep 13, 2024

Sure Sure. Will Edit the PR

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this if we start swayosd-server and invoke using swayosd-client

@rubiin
Copy link
Contributor

rubiin commented Sep 13, 2024

btw @TheyCallMeSecond can you also compare the memory usage of hyprpanel and waybar. I am skeptical on the memory part of hyprpanel as its on typescript afaik

Also hyprpanel has inbuilt osd https://hyprpanel.com/configuration/osd.html so swayosd would not be needed i guess

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Sep 13, 2024

image < 100

image > 150

@rubiin
Copy link
Contributor

rubiin commented Sep 13, 2024

I was afraid of that, thats like twice the memory. Because typescript is not so great on memory . I think I will stick to waybar for now

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Sep 13, 2024

This repo will always use waybar by default unless tittu will change it.

What I can do is to make integration with external dotfiles to hyde. I'm looking forward to swayosd as this one requires minimal change. ie the volume and backlight script PR. that one doesn't require extra configuration for the users.

@rubiin
Copy link
Contributor

rubiin commented Sep 13, 2024

This repo will always use waybar by default unless tittu will change it.

What I can do is to make integration with external dotfiles to hyde. I'm looking forward to swayosd as this one requires minimal change. ie the volume and backlight script PR. that one doesn't require extra configuration for the users.

yeah. hyprpanel is a big change.

@rubiin
Copy link
Contributor

rubiin commented Sep 13, 2024

@kRHYME7 using ags . The creators dotfiles
Looks like everything is covered. There is notification center, osd and bar
Ags replaces waybar, swaync, nwg-drawer, rofi

image

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Sep 13, 2024

Hyprpanel is built over ags,

@rubiin
Copy link
Contributor

rubiin commented Sep 14, 2024

Hyprpanel is built over ags,

yeah . But depends if how much you can customize

@TheyCallMeSecond
Copy link
Author

@kRHYME7 using ags . The creators dotfiles Looks like everything is covered. There is notification center, osd and bar Ags replaces waybar, swaync, nwg-drawer, rofi

image

im using ags like this right now
im testing HyprPanel for 2 days now...had some minor bugs but i fixed that easily and now working fine

GXcDJBxXcAA4VPV

@rubiin
Copy link
Contributor

rubiin commented Sep 14, 2024

the panel can wait but i think we should implement this first. #1173
Its more of a required feature @kRHYME7

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Sep 14, 2024

Got more bugs from hyprpanel, but overall we can support wallbash and theming. So HyDE + HyprPanel is achievable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants